Conversation
artfwo
approved these changes
Apr 21, 2026
encrypt94
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sooo i have on my personal machine retired windows and swapped to nixos, so some tiny things to make compilation on there nicer.
We do assume all QT-tools to be in a folder relative to QT_TOOL_PATH - which we pull from qmllint.
On nixos this fails as qmllint comes from package qtdeclarative and lupdate from package qttools. So they are in diffrent folders.
So let's prefer the current approach but fallback to a generic $PATH search if we cannot resolve the executables otherwise.